[v12] feat(ui-form-field): rework FormFieldGroup #2311
Conversation
|
| label: 'formFieldGroup', | ||
| border: `${componentTheme.borderWidth} ${componentTheme.borderStyle} ${componentTheme.borderColor}`, | ||
| borderRadius: componentTheme.borderRadius, |
There was a problem hiding this comment.
these tokens were used for the old error style (border around all the children, newError style does not use them), but I forgot to remove them form here: #2273
| const generateStyle = ( | ||
| componentTheme: FormFieldGroupTheme, | ||
| _componentTheme: FormFieldGroupTheme, |
There was a problem hiding this comment.
Both FormFieldGroup and FormFieldMessages are components that have no tokens anymore and therefore the style.ts files have no theme.
There was a problem hiding this comment.
Can you remove the FormFieldGroupTheme type, its not used? As I see in withStyle its always an empty object, so it can be like this:
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
_componentTheme: {},
There was a problem hiding this comment.
I removed it like that above
ToMESSKa
force-pushed
the
INSTUI-4871-form-field-group-rework
branch
from
4549eee to
e2711a5
Compare
ToMESSKa
changed the title
| const generateStyle = ( | ||
| componentTheme: FormFieldGroupTheme, | ||
| _componentTheme: FormFieldGroupTheme, |
There was a problem hiding this comment.
Can you remove the FormFieldGroupTheme type, its not used? As I see in withStyle its always an empty object, so it can be like this:
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
_componentTheme: {},
INSTUI-4871
ToMESSKa
force-pushed
the
INSTUI-4871-form-field-group-rework
branch
from
e2711a5 to
a7242d7
Compare
INSTUI-4871
ISSUE:
TEST PLAN: